Re: [PATCH 2/2] USB: serial: add dell wwan card(413c:81a9)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2014-03-28 at 11:25 +0100, Bjørn Mork wrote:
> Johan Hovold <jhovold@xxxxxxxxx> writes:
> 
> > [ +CC: Dan and Bjørn ]
> >
> > On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
> >> This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
> >> Mobile Broadband Card.
> >
> > Shouldn't this device be handled by the option driver?
> >
> > In fact, PID 0x8133 for 5720 VZW (which your clean-up patch touches)
> > is listed in both option and sierra.
> >
> > I think we need to revert 1ebca9dad5ab ("USB: serial: add usbid for dell
> > wwan card to sierra.c").
> 
> Maybe. If nothing else, additional PID digit in that patch looks a bit
> silly :-)
> 
> It would be good to have a bit more information about these modules.  As
> you know, but the reporters may not be aware of, the fact that they are
> made by Sierra does not necessarily mean that they are supported by the
> sierra driver.  That will depend on the chipset and firmware.
> 
> Just as an example: My Sierra Wireless MC7710 works fine with the sierra
> driver if it is in "DirectIP" mode (using a 0x68a3 PID).  But it fails
> the sierra_set_power_state() control message I configure it for "QMI"
> mode (using a 0x68a2 PID), adding a 5 second delay for every serial port
> probed.  This delay isn't necessarily noticed by the reporter... The
> 0x68a2 PID was also originally added to the sierra driver, and it did
> sort of work.
> 
> I think we'd like to see at least a dmesg snippet with time stamps
> showing the actual probing before accepting any new device into the
> "sierra" driver.  We do not want to add any device which does not
> understand the Sierra vendor specific control messages.
> 
> And it would also be preferable to have a lsusb -v listing or similar,
> so that we can match the different functions against other Sierra
> devices.  Sierra have been using a system with fixed interface numbers
> for different vendor specific functions lately.  The sierra driver has
> knowledge about this.  That's what the &direct_ip_interface_blacklist is
> for.  I'm pretty sure that any new Sierra module will need to have this
> blacklist enabled, even if it turns out that the sierra driver is
> correct.

The Dell drivers use the same configuration for PIDs:

81A2: Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card
81A3: Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card
81A4: Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card
81A8: Dell Wireless 5808 Gobi(TM) 4G LTE Mobile Broadband Card
81A9: Dell Wireless 5808e Gobi(TM) 4G LTE Mobile Broadband Card

These devices are all clearly Sierra devices, but are also definitely
Gobi-based.  The A8 might be the MC7700/7710 and A9 is likely a MC7750.

>From DellGobi5kSetup.exe from the Dell drivers:

usbif0: serial/firmware loader?
usbif2: nmea
usbif3: modem/ppp
usbif8: net/QMI

If Bjorn is right about Sierra using the fixed interface numbers for the
different functions, then perhaps the other USB interfaces (1, 4, 5, 6,
7) would be active when the device is in Direct IP mode?

Dan

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux