On Fri, Mar 28, 2014 at 11:25:23AM +0100, Bjørn Mork wrote:
> Johan Hovold <jhovold@xxxxxxxxx> writes:
> > [ +CC: Dan and Bjørn ]
> >
> > On Fri, Mar 28, 2014 at 03:25:06PM +0800, AceLan Kao wrote:
> >> This patch adds support for Dell Computer Corp. Wireless 5808e 4G LTE
> >> Mobile Broadband Card.
> >
> > Shouldn't this device be handled by the option driver?
> >
> > In fact, PID 0x8133 for 5720 VZW (which your clean-up patch touches)
> > is listed in both option and sierra.
> >
> > I think we need to revert 1ebca9dad5ab ("USB: serial: add usbid for dell
> > wwan card to sierra.c").
>
> Maybe. If nothing else, additional PID digit in that patch looks a bit
> silly :-)
Indeed. But lets decide what driver should actually be claiming the
device first. :)
> It would be good to have a bit more information about these modules. As
> you know, but the reporters may not be aware of, the fact that they are
> made by Sierra does not necessarily mean that they are supported by the
> sierra driver. That will depend on the chipset and firmware.
>
> Just as an example: My Sierra Wireless MC7710 works fine with the sierra
> driver if it is in "DirectIP" mode (using a 0x68a3 PID). But it fails
> the sierra_set_power_state() control message I configure it for "QMI"
> mode (using a 0x68a2 PID), adding a 5 second delay for every serial port
> probed. This delay isn't necessarily noticed by the reporter... The
> 0x68a2 PID was also originally added to the sierra driver, and it did
> sort of work.
Seems to me that some error messages are missing from the sierra driver
when sierra_set_power_state (and sierra_vsc_set_nmea) fails then.
> I think we'd like to see at least a dmesg snippet with time stamps
> showing the actual probing before accepting any new device into the
> "sierra" driver. We do not want to add any device which does not
> understand the Sierra vendor specific control messages.
AceLan, could you provide such logs from when plugging the device in
(with your patch applied). Please also include the output of
lsusb -vd 413c:81a9
> And it would also be preferable to have a lsusb -v listing or similar,
> so that we can match the different functions against other Sierra
> devices. Sierra have been using a system with fixed interface numbers
> for different vendor specific functions lately. The sierra driver has
> knowledge about this. That's what the &direct_ip_interface_blacklist is
> for. I'm pretty sure that any new Sierra module will need to have this
> blacklist enabled, even if it turns out that the sierra driver is
> correct.
I found lsusb output for 0x8133 (currently claimed by both sierra and
option):
Bus 004 Device 002: ID 413c:8133 Dell Computer Corp.
Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 1.10
bDeviceClass 0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 64
idVendor 0x413c Dell Computer Corp.
idProduct 0x8133
bcdDevice 0.00
iManufacturer 1
iProduct 2
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 62
bNumInterfaces 2
bConfigurationValue 1
iConfiguration 0
bmAttributes 0xe0
Self Powered
Remote Wakeup
MaxPower 100mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 3
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0010 1x 16 bytes
bInterval 128
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 1
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 3
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84 EP 4 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x04 EP 4 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
source: http://marc.info/?l=linux-usb&m=120382252726528&w=2
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
