From: Sarah> Sharp > On Wed, Feb 05, 2014 at 09:44:20AM +0000, David Laight wrote: > > From: Mark Lord > > > >> Which means that the controller is obeying the rules, and the software is wrong. > > > .. > > > > In this case, the bug has been worked around (not perfectly), but we've > > > > had no customer reports that this is an issue. There is no user-visible > > > > impact as far as we know. So fixing this race condition is a really low > > > > priority for me, and the fix would have to very minimally touch the > > > > driver. > > > > I'm seeing the problem with the ASMedia controller (rev 0.96). > > Your fix is only active for rev 1.00 controllers. > > Ok, then let's add a quirk for that host. Are you sure you don't need > XHCI_TRUST_TX_LENGTH instead of XHCI_SPURIOUS_SUCCESS? Will reported > seeing messages about needing XHCI_TRUST_TX_LENGTH. No, the ASMedia controller reports short receives correctly. I'd be seriously tempted to make both of those 'quirks' unconditional. For short receives just comment that many controllers don't get it right. After all the code is always doing the check, and the rest is just annoying and forcing people to work out which quirk to set and how to rebuild the driver. If it were only a single 'rogue' implementation the quirk would be fine. David -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
