Re: [PATCH 1/4] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark

"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> · Mon, 15 Apr 2019 14:05:54 +0300

On 9.04.19 г. 18:44 ч., Slavomir Kaslev wrote:

The problem is the way they are defined atm:

# First search in the user provided paths.
find_path(TRACECMD_BIN_DIR      NAMES  trace-cmd
                                 PATHS  $ENV{TRACE_CMD}/tracecmd/
                                        ${CMAKE_SOURCE_DIR}/../tracecmd/
                                 NO_DEFAULT_PATH)

This will never evaluate to /usr/bin which is what it should be for
distro builds.

I think there is a bit of confusion here. The code above will never 

search in /usr/bin. This statement is correct.

However if this search fails we will perform another search that will 

this time search in /usr/bin. Look few lines below in  FindTraceCmd.cmake.

The reason for this is to avoid confusion in the case when the user has 

the distro package installed, but in the same time is trying to build 

KernelShark from source. We want in this case the GUI to link with the 

version of the trace-cmd library that is being build (not the one from 

the package).

Thanks!
Yordan