On 9.04.19 г. 18:44 ч., Slavomir Kaslev wrote:
KS_DIR is used runtime to load plugins, as default path for file open
dialogs (which doesn't make much sense imo) and at compile time to
construct relative paths in the source directory. It is currently
defined simply as
set(KS_DIR ${CMAKE_SOURCE_DIR})
I think there needs to be a separate constant for plugins path that
can be set at build time and in distro build can point to
/usr/share/kernelshark/plugins or somewhere where we want shared
plugins to live.
Yes. No doubt that this must be separated.
The compile time uses of KS_DIR are fine though
${CMAKE_SOURCE_DIR} is clearer for the reader. The default directory
for file open dialogs can be the current directory or the last opened
path rather than the kernelshark source directory.
What do you think?
I still think that if you build KernelShark from source, the most natural default path for the open-file dialogs is the trace-cmd/kernel-shark directory. However if this directory doesn't exist the dialogs can start at ${HOME} (the one of the user running the app).
I still think that if you build KernelShark from source, the most natural default path for the open-file dialogs is the trace-cmd/kernel-shark directory. However if this directory doesn't exist {distro installation} the dialogs can start at ${HOME} (the one of the user running the app).
What do you think? Thanks! Yordan
|