On Tue, Apr 9, 2019 at 4:24 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Tue, 9 Apr 2019 15:23:56 +0300 > "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote: > > > I can make the GUI to check if _KS_CACHE_DIR is defined and if its value > > (path) belongs to the user who runs the GUI. If this is not the case, > > The GUI will use the default location (~/cache/kernelshark). > > Can't we just make it so that it always does this path? Dropping KS_CACHE_DIR as build time constant in CMake sounds great. I think that having an environment variable override for it is still useful. We also have the same problem with KS_DIR and TRACECMD_BIN_DIR though. They both point inside the trace-cmd source directory for the user who built kernelshark atm. Cheers, -- Slavi
|