On Mon, 2019-04-15 at 14:05 +0300, Yordan Karadzhov (VMware) wrote:
>
> On 9.04.19 г. 18:44 ч., Slavomir Kaslev wrote:
> > The problem is the way they are defined atm:
> >
> > # First search in the user provided paths.
> > find_path(TRACECMD_BIN_DIR NAMES trace-cmd
> > PATHS $ENV{TRACE_CMD}/tracecmd/
> > ${CMAKE_SOURCE_DIR}/../trac
> > ecmd/
> > NO_DEFAULT_PATH)
> >
> > This will never evaluate to /usr/bin which is what it should be for
> > distro builds.
>
> I think there is a bit of confusion here. The code above will never
> search in /usr/bin. This statement is correct.
>
> However if this search fails we will perform another search that
> will
> this time search in /usr/bin. Look few lines below
> in FindTraceCmd.cmake.
Ah, I missed that.
>
> The reason for this is to avoid confusion in the case when the user
> has
> the distro package installed, but in the same time is trying to
> build
> KernelShark from source. We want in this case the GUI to link with
> the
> version of the trace-cmd library that is being build (not the one
> from
> the package).
So how should I build kernelshark after a clean git clone for a distro
build? In particular, what sequence of commands do I need to run so
that I get fully build kernelshark with all constants pointing to the
correct places (say TRACECMD_BIN_DIR = /usr/bin). If this is not
supporeted yet (and I think it's not atm), we should at least have a
plan how we want to go about doing it. A script doing something is
always better that documenting how to achieve the same.
-- Slavi
>
> Thanks!
> Yordan
>
>
|