* Steven Rostedt (rostedt@xxxxxxxxxxx) wrote: > On Wed, 2009-12-02 at 17:36 -0500, Masami Hiramatsu wrote: > > > > Or do you (or anyone else) have a better name? > > > > How about renaming DEFINE_EVENT to TRACE_EVENT_CLASS? > > > > DECLARE_EVENT_CLASS(y, ...) declare an event-class y > > TRACE_EVENT_CLASS(x, y, ...) define/declare a trace event x from event-class y > > TRACE_EVENT(x, ...) define/declare a trace event x > > > > Thus TRACE_EVENT_* implies that this macro will be expanded > > to both of definition and declaration. > > I don't think separating it is good idea from the viewpoint > > of maintaining code. > > Hmm, what about just: > > TRACE_CLASS - Declares a class > TRACE_CLASS_EVENT - defines an event for said class > TRACE_EVENT - Declares a class and defines an event (as is today) In addition, I wonder if we should rename "CREATE_TRACE_POINTS" to something more suitable while we are here ? Basically, it will affect all TRACE_CLASS/TRACE_CLASS_EVENT/TRACE_EVENT from headers included after it's defined. It sounds to me that this "CREATE_TRACE_POINTS" is the define that controls whether the TRACE_* will actually turn into a DECLARE or a DEFINE. I agree that the standard behavior should be to "DECLARE" stuff, as it's the, by far, most common case, but maybe #define TRACE_DEFINE #include <trace/events/....h> would be more descriptive than "CREATE_TRACE_POINTS", given it refers to the well-known "define" semantic ? So if we happen to have C file which need many headers to be declared but only some of them to be defined, we could express it as: #include <trace/events/sched.h> #include <trace/events/irq.h> #include <trace/events/timer.h> #define TRACE_DEFINE #include <trace/events/irq.h> #include <trace/events/timer.h> #undef TRACE_DEFINE That would imply that any definition of a trace event header should be preceded by an inclusion of this same header to perform the declaration. This would clearly separate the declaration from definition. Does it make sense ? Mathieu -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
|