Re: trace/events: DECLARE vs DEFINE semantic
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: trace/events: DECLARE vs DEFINE semantic
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Wed, 02 Dec 2009 17:46:45 -0500
- Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxx>, mingo@xxxxxxxxxx, hpa@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, randy.dunlap@xxxxxxxxxx, wcohen@xxxxxxxxxx, fweisbec@xxxxxxxxx, tglx@xxxxxxxxxxxxx, jbaron@xxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
- In-reply-to: <4B16EC06.6010706@xxxxxxxxxx>
- Organization: Kihon Technologies Inc.
- References: <tip-3a9089fd78367e2c6c815129030b790a0f5c2715@xxxxxxxxxxxxxx> <1259761934.12870.12.camel@xxxxxxxxxxxxxxxxxxx> <20091202140128.GA2611@xxxxxxx> <1259764109.12870.37.camel@xxxxxxxxxxxxxxxxxxx> <20091202144334.GA30359@xxxxxxx> <1259765735.12870.42.camel@xxxxxxxxxxxxxxxxxxx> <20091202162715.GB9710@Krystal> <1259773888.12870.61.camel@xxxxxxxxxxxxxxxxxxx> <20091202180633.GF9710@Krystal> <1259777987.12870.70.camel@xxxxxxxxxxxxxxxxxxx> <20091202190135.GA23316@Krystal> <1259781578.12870.78.camel@xxxxxxxxxxxxxxxxxxx> <4B16EC06.6010706@xxxxxxxxxx>
- Reply-to: rostedt@xxxxxxxxxxx
On Wed, 2009-12-02 at 17:36 -0500, Masami Hiramatsu wrote:
> > Or do you (or anyone else) have a better name?
>
> How about renaming DEFINE_EVENT to TRACE_EVENT_CLASS?
>
> DECLARE_EVENT_CLASS(y, ...) declare an event-class y
> TRACE_EVENT_CLASS(x, y, ...) define/declare a trace event x from event-class y
> TRACE_EVENT(x, ...) define/declare a trace event x
>
> Thus TRACE_EVENT_* implies that this macro will be expanded
> to both of definition and declaration.
> I don't think separating it is good idea from the viewpoint
> of maintaining code.
Hmm, what about just:
TRACE_CLASS - Declares a class
TRACE_CLASS_EVENT - defines an event for said class
TRACE_EVENT - Declares a class and defines an event (as is today)
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
- References:
- [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- From: tip-bot for Jason Baron
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- Re: [tip:perf/core] tracing: Add DEFINE_EVENT(), DEFINE_SINGLE_EVENT() support to docbook
- trace/events: DECLARE vs DEFINE semantic
- Re: trace/events: DECLARE vs DEFINE semantic
- Re: trace/events: DECLARE vs DEFINE semantic
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]