Re: trace/events: DECLARE vs DEFINE semantic
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: trace/events: DECLARE vs DEFINE semantic
- From: Steven Rostedt <rostedt@xxxxxxxxxxx>
- Date: Wed, 02 Dec 2009 18:13:25 -0500
- Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxx>, mingo@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, randy.dunlap@xxxxxxxxxx, wcohen@xxxxxxxxxx, fweisbec@xxxxxxxxx, tglx@xxxxxxxxxxxxx, jbaron@xxxxxxxxxx, linux-tip-commits@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
- In-reply-to: <4B16F389.4090801@xxxxxxxxx>
- Organization: Kihon Technologies Inc.
- References: <20091202144334.GA30359@xxxxxxx> <1259765735.12870.42.camel@xxxxxxxxxxxxxxxxxxx> <20091202162715.GB9710@Krystal> <1259773888.12870.61.camel@xxxxxxxxxxxxxxxxxxx> <20091202180633.GF9710@Krystal> <1259777987.12870.70.camel@xxxxxxxxxxxxxxxxxxx> <20091202190135.GA23316@Krystal> <1259781578.12870.78.camel@xxxxxxxxxxxxxxxxxxx> <4B16EC06.6010706@xxxxxxxxxx> <1259794005.12870.102.camel@xxxxxxxxxxxxxxxxxxx> <20091202225736.GA14770@Krystal> <4B16F389.4090801@xxxxxxxxx>
- Reply-to: rostedt@xxxxxxxxxxx
On Wed, 2009-12-02 at 15:08 -0800, H. Peter Anvin wrote:
> On 12/02/2009 02:57 PM, Mathieu Desnoyers wrote:
> >>
> >> TRACE_CLASS - Declares a class
> >> TRACE_CLASS_EVENT - defines an event for said class
> >> TRACE_EVENT - Declares a class and defines an event (as is today)
> >
> > Yep, it looks good! It's self-descriptive and don't require to explain
> > what the thing is doing each time we refer to it. (however I feel a bit
> > sad for Fred, Wilma and Barney) ;)
> >
>
> Although you have to admit it's a bit confusing that:
>
> TRACE_EVENT = TRACE_CLASS + TRACE_CLASS_EVENT
>
> ... as opposed to ...
>
> TRACE_CLASS_EVENT = TRACE_CLASS + TRACE_EVENT
Fred, Wilma and Barney are sounding better by the second.
So, would you think:
TRACE_CLASS - Declare a class
TRACE_EVENT - defines an event for said class (different meaning than before)
TRACE_CLASS_EVENT - Declares a class and an event
is the better naming?
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-tip-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Index of Archives]
[Linux Stable Commits]
[Linux Stable Kernel]
[Linux Kernel]
[Linux USB Devel]
[Linux Video &Media]
[Linux Audio Users]
[Yosemite News]
[Linux SCSI]