On Thu, Jul 13, 2023 at 07:49:39PM -0700, Tree Davies wrote: > On Thu, Jul 13, 2023 at 11:54:40PM +0200, Philipp Hortmann wrote: > > On 7/13/23 01:35, Tree Davies wrote: > > > Rename variable pBA to pba in order to Fix checkpatch > > > warning: Avoid CamelCase > > > > > > Signed-off-by: Tree Davies<tdavies@xxxxxxxxxxxxxxx> > > > --- > > > drivers/staging/rtl8192e/rtl819x_BAProc.c | 106 +++++++++++----------- > > > drivers/staging/rtl8192e/rtllib.h | 2 +- > > > 2 files changed, 54 insertions(+), 54 deletions(-) > > > > > > Hi Tree, > > the p is typically for pointer. This is not wanted when you change the name. > > But ba is is in use.... > > > > Bye Philipp > > Thanks Philipp, > > A few thoughts... > Looking at occurances of pBA, they all appear as local variable > declarations of struct ba_record, mostly as function params. I'm reading my inbox in the wrong order so I already sent an email with the same advice that Philipp sent. Philipp is correct. "p" is not allowed. > > I also see what you mentioned, as BA being already taken in > rtl819x_BAProc.c:394 and line 292, but I don't 'think' that renaming them > both to ba will result negatively(?). Thanks for noticing this. Figure out a solution. > > Agreed, let's wait on Greg. Heh. Greg is not going to fix these minor issues and neither am I. We trust you to find a solution. You can do it! I believe in you! regards, dan carpenter
