On 7/14/23 04:49, Tree Davies wrote:
On Thu, Jul 13, 2023 at 11:54:40PM +0200, Philipp Hortmann wrote:
On 7/13/23 01:35, Tree Davies wrote:
Rename variable pBA to pba in order to Fix checkpatch
warning: Avoid CamelCase
Signed-off-by: Tree Davies<tdavies@xxxxxxxxxxxxxxx>
---
drivers/staging/rtl8192e/rtl819x_BAProc.c | 106 +++++++++++-----------
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 54 insertions(+), 54 deletions(-)
Hi Tree,
the p is typically for pointer. This is not wanted when you change the name.
But ba is is in use....
Bye Philipp
Thanks Philipp,
A few thoughts...
Looking at occurances of pBA, they all appear as local variable
declarations of struct ba_record, mostly as function params.
I also see what you mentioned, as BA being already taken in
rtl819x_BAProc.c:394 and line 292, but I don't 'think' that renaming them
both to ba will result negatively(?).
Agreed, let's wait on Greg.
Cheers!
Tree
Hi Tree,
it is not so much about the compiler or if it works this way. When I
read a program I often use Ctrl+Shift+F what shows me all variables in
one folder (driver). I expect that I then always see one variable for
one use and do not have to do a one by one decision if this belongs to
the one content or to the other.
Please consider "readability" is important for kernel code.
Thanks for your support.
Bye Philipp
