On Mon, Nov 30, 2015 at 01:04:52PM +0000, kernel@xxxxxxxxxxxxxxxx wrote: > +static struct spi_res *__spi_res_alloc(struct spi_device *spi, > + spi_res_release_t release, > + size_t size, > + gfp_t gfp) This has exactly one (tiny) user. Why is it a separate function? > + sres = kzalloc(tot_size, gfp); > + if (unlikely(!sres)) > + return NULL; Don't use likely() or unlikely() annotations unless the code is *really* performance critical, just let the optimiser get on with things. The annotations most likely cost more time in reading the code than they'll ever save.
Attachment:
signature.asc
Description: PGP signature
