Re: [PATCH v1 2/2] spi: pxa2xx: replace ugly table by approximation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 25, 2015 at 12:37:45PM +0200, Andy Shevchenko wrote:
> On Tue, 2015-03-24 at 09:59 -0700, Mark Brown wrote:

> > I'm not sure that
> > one could reasonably expect someone to follow this code without doing
> > detective work.  I think the biggest thing is that the comments aren't
> > saying why the code is doing what it's doing.

> Should I cite data sheet in case to explain some branches?

Yes, that should be helpful.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux