Re: [PATCH v1 2/2] spi: pxa2xx: replace ugly table by approximation

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, 2015-03-25 at 08:17 -0700, Mark Brown wrote:
> On Wed, Mar 25, 2015 at 12:37:45PM +0200, Andy Shevchenko wrote:
> > On Tue, 2015-03-24 at 09:59 -0700, Mark Brown wrote:
> 
> > > I'm not sure that
> > > one could reasonably expect someone to follow this code without doing
> > > detective work.  I think the biggest thing is that the comments aren't
> > > saying why the code is doing what it's doing.
> 
> > Should I cite data sheet in case to explain some branches?
> 
> Yes, that should be helpful.

I early today sent v2, I hope it becomes more clear.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html