On Wed, Mar 25, 2015 at 08:10:57AM +0100, Martin Sperl wrote: > +static inline void bcm2835_set_cs(struct spi_device *spi, bool enable) > +{ > + if (spi->mode & SPI_CS_HIGH) > + enable = !enable; > + > + if (gpio_is_valid(spi->cs_gpio)) > + gpio_set_value(spi->cs_gpio, !enable); > +} This appears to be open coding the core spi_set_cs() support for GPIOs, why are we not just setting cs_gpio and letting the core take care of things?
Attachment:
signature.asc
Description: Digital signature