On Thu, Feb 2, 2017 at 11:51 PM, Okash Khawaja <okash.khawaja@xxxxxxxxx> wrote: > Hi, > > On Sat, Jan 28, 2017 at 6:56 PM, Okash Khawaja <okash.khawaja@xxxxxxxxx> wrote: >> On Sat, Jan 28, 2017 at 6:30 PM, Samuel Thibault >> <samuel.thibault@xxxxxxxxxxxx> wrote: >>> Okash Khawaja, on Sat 28 Jan 2017 18:29:03 +0000, wrote: >>>> It's SSH into Linux VM which runs speakup_dummy, so running pseudo >>>> terminal. Should be okay? >>> >>> Yes, but then don't be surprised that speakup doesn't print anything: >>> nothing is happening on the linux text console :) You need to log into >>> the linux text console and do stuff there to get speakup to speak it. >> >> My mistake. For some reason I thought espeakup was working with my >> xterm which also uses pseudo terminal which led me to (misguided) >> belief that it should work for SSH connection too. Thanks, it's >> looking better now :) >>> >>> Samuel > > I have attached the patch which uses tty for speakup_dummy. It applies > without conflicts to 4.10.x kernel code but showed conflicts for > 4.8.6. Please note that major and minor device numbers are hard coded > as 4 and 64 inside spk_ttyio_initialise() function. I have changed > names slightly, so there is spk_ttyio_* prefix which identifies > functions related to tty-based comms. The related code is grouped > inside spk_ttyio.c file. > > I noticed that `startup` member of synth_dummy instance was set to > SYNTH_START which meant that probe function for dummy won't be called > when built into kernel image. May be I didn't understand it fully, but > for now I have changed to always be the literal 1. > > Tested dummy and also soft synth/espeakup for regressions. Both seemed > okay but I didn't fully test them. Any ideas for testing will be > useful. > > Thanks, > Okash Attaching gzipped patch due to attachment size limits on the mailing list. _______________________________________________ Speakup mailing list Speakup@xxxxxxxxxxxxxxxxx http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
