Re: Line discipline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 28, 2017 at 5:57 PM, Samuel Thibault
<samuel.thibault@xxxxxxxxxxxx> wrote:
> Okash Khawaja, on Sat 28 Jan 2017 17:49:01 +0000, wrote:
>> Added tty_ldisc_release() which resolved the problem.
>
> Ok, good.
>
>> Also added tty_ldisc_flush() before tty_ldisc_release().
>
> I don't think it's really needed since the user is asking for speakup to
> go away anyway, but it shouldn't hurt.
>
>> Wouldn't it be safer to add those functions before tty_unlock()?
>
> See callers of these, they don't lock the tty.
>
>> The only output I get from speakup_dummy is:
>>
>> Speakup
>> RATE 8
>> PITCH 8
>> VOL 8
>> TONE 8
>> Dummy found
>
> But are you working on the linux text console?

It's SSH into Linux VM which runs speakup_dummy, so running pseudo
terminal. Should be okay?

>
> Samuel
_______________________________________________
Speakup mailing list
Speakup@xxxxxxxxxxxxxxxxx
http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup




[Index of Archives]     [Linux for the Blind]     [Fedora Discussioin]     [Linux Kernel]     [Yosemite News]     [Big List of Linux Books]
  Powered by Linux