Hi Samuel, Combined the refactor changes with your tty code to test speakup_dummy. It seems okay except for problem when unloading speakup.ko - it is in use so can't be unloaded. I have just got this so investigating it. One question. Using your code, we can obtain tty, cache it and use it directly for all subsequent writes. Why then use ldisc? Thanks, Okash On Mon, Dec 26, 2016 at 4:02 PM, Okash Khawaja <okash.khawaja@xxxxxxxxx> wrote: > Thanks. It seems relatively straightforward from here on. Job switch > combined with an unexpectedly busy holiday period means that I haven't been > able to work on this recently. Things will settle next week when I will be > back on it. > > Merry Christmas and happy new year! > > Okash > > > On 20 Dec 2016, at 01:08, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> > wrote: > > > > Okash Khawaja, on Sun 18 Dec 2016 11:24:11 +0000, wrote: > >> Now I see three items to address, listed below in no particular order. > >> > >> 1. Supplying major and minor dev numbers, instead of hardcoding. > > > > This could be a mere module parameter string that a function turns into > > major/minor. Not a big deal :) > > > >> 2. Integrating the changes into speakup_dummy and testing it. > > > > Yep! > > > >> 3. Strategy for kernel patch. Do we try to have it accepted? Not sure > if there > >> is a standard way of addressing it. > > > > It will never be accepted before step 2. is done. In the end we'll want > > to get it accepted, sure, but we have to make speakup able to use it > > first, otherwise the kernel patch will be rejected. > > > > Thanks! > > Samuel > _______________________________________________ Speakup mailing list Speakup@xxxxxxxxxxxxxxxxx http://linux-speakup.org/cgi-bin/mailman/listinfo/speakup
