On 28 February 2018 at 10:01, Christopher Li <sparse@xxxxxxxxxxx> wrote: > On Tue, Feb 27, 2018 at 5:30 AM, Dibyendu Majumdar > <mobile@xxxxxxxxxxxxxxx> wrote: >> >> >> Hi Chris, does operand_size() in simplify need to look at pseudo value size? > > Not sure, operand_size() is only use in OP_ASR. As far as I can tell, > sparse never generate OP_ASR, so that code path is not executed. > > The current operand_size() is returning the sign extended highest bit size. > Sparse currently does sign extend before put into the value field. > If you use the pseudo->size, it will behave differently than the current > operand_size(). It does not do sign extended. > > My reading of simplify_asr(), that function seems a little bit problematic. > ASR(-1, shift_bits) should always be -1, not 0. > Okay, so I am trying to understand where in the simplification phase the size of the value pseudo used. This was the only place I could find. Although now multiple value pseudos are created - I guess the actual value is still the same, and if the size of the value pseudo does not play a part in simplification then sure this change cannot cause a change in the simplification process? Or am I missing something? Regards Dibyendu -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
