On Tue, Feb 27, 2018 at 5:30 AM, Dibyendu Majumdar <mobile@xxxxxxxxxxxxxxx> wrote: > > > Hi Chris, does operand_size() in simplify need to look at pseudo value size? Not sure, operand_size() is only use in OP_ASR. As far as I can tell, sparse never generate OP_ASR, so that code path is not executed. The current operand_size() is returning the sign extended highest bit size. Sparse currently does sign extend before put into the value field. If you use the pseudo->size, it will behave differently than the current operand_size(). It does not do sign extended. My reading of simplify_asr(), that function seems a little bit problematic. ASR(-1, shift_bits) should always be -1, not 0. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html