On Mon, Dec 14, 2015 at 04:59:45PM +0100, Thomas Gleixner wrote: > On Mon, 14 Dec 2015, Boqun Feng wrote: > > Probably something like this(untested, only run "make kernel/irq/")? > > > > Subject: [RFC v2 3/3] irq: Privatize irq_common_data::state_use_accessors > > > > According to Peter Zijlstra, irq_common_data::state_use_accessors is not > > designed for public use. Therefore make it private so that people who > > write code accessing it directly will get blamed by sparse. > > > > Also macro __irqd_to_state() is for _designed_ accesses to irq_data's > > state only, it's better to limit its scope, therefore put all its > > callers together and #undef it after use. > > That exposes the set/clr functions to the global header file, while > today those are restricted to the core internals header. There is a > reason why I did not make them public .... > Oops, I wasn't aware of that... then I guess we should define and undef __irqd_to_state twice, in include/linux/irq.h and in kernel/irq/internals.h, right? Regards, Boqun
Attachment:
signature.asc
Description: PGP signature
