Re: [RFC 3/3] irq: Privatize irq_common_data::state_use_accessors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 14 Dec 2015, Boqun Feng wrote:
> Probably something like this(untested, only run "make kernel/irq/")?
> 
> Subject: [RFC v2 3/3] irq: Privatize irq_common_data::state_use_accessors
> 
> According to Peter Zijlstra, irq_common_data::state_use_accessors is not
> designed for public use. Therefore make it private so that people who
> write code accessing it directly will get blamed by sparse.
> 
> Also macro __irqd_to_state() is for _designed_ accesses to irq_data's
> state only, it's better to limit its scope, therefore put all its
> callers together and #undef it after use.

That exposes the set/clr functions to the global header file, while
today those are restricted to the core internals header. There is a
reason why I did not make them public ....

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux