On Fri, Sep 13, 2024 at 02:24:20PM -0400, Parker Newman wrote: > On Fri, 13 Sep 2024 20:48:03 +0300 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Fri, Sep 13, 2024 at 10:55:38AM -0400, Parker Newman wrote: ... > > > Link: https://ww1.microchip.com/downloads/en/DeviceDoc/Atmel-5193-SEEPROM-AT93C46D-Datasheet.pdf > > > > Make it a tag (i.e. locate just above your SoB tag) > > Sorry, not 100% sure what you mean by tag? Do I just need to move the Link: entry > to be above my Sign-off? Or is there something else? Thanks! Make it like ...Summary... <blank line> ...commit message text... <blank line> Link: ... Signed-off-by: ... ... > > > + if (has_quirk_extra_read_cycle(eeprom)) { > > > + eeprom_93cx6_pulse_high(eeprom); > > > > No additional delay is needed? > > Should not need any extra delay as both pulse high/low functions have the worst case > 450ns delay after the register write. It was working well on my test cards. OK! > > > + eeprom_93cx6_pulse_low(eeprom); > > > + } -- With Best Regards, Andy Shevchenko
