On Fri, 13 Sep 2024 21:10:01 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Fri, Sep 13, 2024 at 10:55:37AM -0400, Parker Newman wrote: > > From: Parker Newman <pnewman@xxxxxxxxxxxxxxx> > > > > This series of patches replaces the custom 93cx6 EEPROM read functions in > > the 8250_exar driver with the eeprom_93cx6 driver. This removes duplicate code > > and improves code readability. > > > > In order to use the eeprom_93cx6 driver a quirk needed to be added to add an > > extra clock cycle before reading from the EEPROM. This is similar to the > > quirk in the eeprom_93xx46 driver. > > > > More details in associated patch and mailing list discussion with > > Andy Shevchenko about these changes: > > Link: https://lore.kernel.org/linux-serial/Ztr5u2wEt8VF1IdI@xxxxxxxxxxxxxxxxxx/ > > Thanks for the prompt update! > > However we are close to the merge window, I think Greg won't accept this until > v6.12-rc1 is out. So, we have a two or three weeks of time. > > Meanwhile I have some (small) comments, I just sent in individual replies. > Overall, LGTM. > Thanks for the review! I will create a v2 with your feedback some time next week. Parker