Hi, On Thu Oct 26, 2023 at 1:13 PM CEST, Ilpo Järvinen wrote: > On Thu, 26 Oct 2023, Théo Lebrun wrote: > > > > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > > index 5774d48c7f16..b2062e4cbbab 100644 > > --- a/drivers/tty/serial/amba-pl011.c > > +++ b/drivers/tty/serial/amba-pl011.c > > @@ -2384,10 +2384,7 @@ static void pl011_console_get_options(struct uart_amba_port *uap, int *baud, > > *parity = 'o'; > > } > > > > - if ((lcr_h & 0x60) == UART01x_LCRH_WLEN_7) > > - *bits = 7; > > - else > > - *bits = 8; > > + *bits = FIELD_GET(0x60, lcr_h) + 5; /* from 5 to 8 inclusive */ > > 0x60 needs to be replaced with a named define! Fixed locally for the next revision, thanks! -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
