Hi, While adding upstream support to a new platform (Mobileye EyeQ5[1]) that uses the AMBA PL011 driver, I took some time to look at the PL011 driver and ended up with a few patches that cleanup parts of it. The line-diff is big mostly because of the checkpatch-fixing commits. The driver hadn't received any love for quite some time. A single commit changes the code's behavior: see "tty: serial: amba-pl011: Parse bits option as 5, 6, 7 or 8 in _get_options". See commit messages for more information. [1]: https://lore.kernel.org/all/202310050726.GDpZbMDO-lkp@xxxxxxxxx/T/ Have a nice day, Théo Lebrun Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> --- Théo Lebrun (6): tty: serial: amba: cleanup whitespace tty: serial: amba: Use BIT() macro for constant declarations tty: serial: amba-pl011: cleanup driver tty: serial: amba-pl011: replace TIOCMBIT macros by static functions tty: serial: amba-pl011: unindent pl011_console_get_options function body tty: serial: amba-pl011: Parse bits option as 5, 6, 7 or 8 in _get_options drivers/tty/serial/amba-pl011.c | 238 ++++++++++++++++++++-------------------- include/linux/amba/serial.h | 192 ++++++++++++++++---------------- 2 files changed, 214 insertions(+), 216 deletions(-) --- base-commit: ad582615776e62e365ab2dfa7a7a3806ada28b30 change-id: 20231023-mbly-uart-afcacbb98f8b Best regards, -- Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
