On Thu, Oct 26, 2023 at 3:19 PM Jiri Slaby <jirislaby@xxxxxxxxxx> wrote: > > On 26. 10. 23, 11:24, Ilpo Järvinen wrote: > > On Thu, 26 Oct 2023, Jiri Slaby wrote: > > > >> On 25. 10. 23, 16:26, Vamshi Gajjela wrote: > >>> From: VAMSHI GAJJELA <vamshigajjela@xxxxxxxxxx> > >>> > >>> The function uart_fifo_timeout() returns an unsigned long value, which is > >>> the number of jiffies. Therefore, the function uart_poll_timeout() has been > >>> modified to use an unsigned long type for timeout values instead of an int > >>> and to avoid truncation. > >> > >> Hi, > >> > >> there is no truncation possible, right? > > > > That's very likely true (I didn't run the calculations), thus it's correct > > to not have Fixes tag. > > Good. I would remove that "and to avoid truncation" completely from the > commit log. I would only say that we are getting things consistent. > > "avoid truncation" can lead to -> we should backport it to stable. And > neither is true. I will drop "and to avoid truncation". > > > It's more about having consistent typing since > > we're talking about jiffies, so unsigned long as usual. > > Yeah and that's of course fine by me. > > thanks, > -- > js > suse labs >
