On 10/06/2023 16:54, Andi Shyti wrote:
> On Sat, Jun 10, 2023 at 04:07:51PM +0200, Christophe JAILLET wrote:
>> Le 10/06/2023 à 12:26, Andi Shyti a écrit :
>>>> @@ -1459,8 +1459,10 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport,
>>>> continue;
>>>> rate = clk_get_rate(clk);
>>>> - if (!rate)
>>>> + if (!rate) {
>>>> + clk_put(clk);
>>>> continue;
>>>
>>> could you also print an error here?
>>>
>>
>> Is:
>> dev_err(ourport->port.dev,
>> "Failed to get clock rate for %s.\n", clkname);
Why do we need it? Most of other users of clk_get_rate() don't print.
Probably because such condition is highly unlikely if not impossible.
This makes simple function unnecessarily bigger...
Best regards,
Krzysztof
