On Fri, Jun 02, 2023 at 06:39:02AM +0000, Mehul Raninga (Temp) (QUIC) wrote: [..] > > On Wed, May 31, 2023 at 01:06:22PM +0000, Mehul Raninga (Temp) > > (QUIC) wrote: [..] > > > > > + if (pm_suspend_via_firmware()) > > > > > > > > I'm not familiar with this api, but aren't all our systems > > > > implementing firmware- assisted suspend? > > > > > > Not all the platform supports deep sleep hence to differentiate if > > > resume is from deep sleep suspend or normal suspend, this api is > > > required. > > > > Can you point me to where this difference in flags is coming from in the > > upstream kernel? > > In upstream kernel by default the flag is false, and for deepsleep > support vendor kernel sets this flag true. I am questioning whether this is correct, given that we indeed "suspend with the help of firmware". But I might be misinterpreting what that statement means. Regards, Bjorn
