Hi Christophe,
On Fri, Jun 09, 2023 at 06:45:38AM +0200, Christophe JAILLET wrote:
> If clk_get_rate() fails, the clk that has just been allocated needs to be
> freed.
>
> Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
As this is a fix, can you cc the stable kernel
Cc: <stable@xxxxxxxxxxxxxxx> # v3.3+
> ---
> drivers/tty/serial/samsung_tty.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 2a7520ad3abd..dd751e7010e3 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1459,8 +1459,10 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport,
> continue;
>
> rate = clk_get_rate(clk);
> - if (!rate)
> + if (!rate) {
> + clk_put(clk);
> continue;
could you also print an error here?
In any case:
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Andi
> + }
>
> if (ourport->info->has_divslot) {
> unsigned long div = rate / req_baud;
> --
> 2.34.1
>
