On Thu, Dec 01, 2022 at 11:06:53AM +0200, Ilpo Järvinen wrote: > On Thu, 1 Dec 2022, Kumaravel Thiagarajan wrote: ... > > +/* > > + * 8250 PCI library header file. > > + * > > + * Copyright (C) 2001 Russell King, All Rights Reserved. > > + */ > > You shouldn't depend on .c file having things included for you. So > please add these: > #include "8250.h" TBH I don't see how this is used here, but types.h for sure is missing. > struct pci_dev; + blank line struct uart_8250_port; > Other than that, > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > > > +int serial8250_pci_setup_port(struct pci_dev *dev, struct uart_8250_port *port, u8 bar, > > + unsigned int offset, int regshift); -- With Best Regards, Andy Shevchenko
