On Thu, 1 Dec 2022, Kumaravel Thiagarajan wrote: > Move implementation of setup_port API to serial8250_pci_setup_port > > Co-developed-by: Tharun Kumar P <tharunkumar.pasumarthi@xxxxxxxxxxxxx> > Signed-off-by: Tharun Kumar P <tharunkumar.pasumarthi@xxxxxxxxxxxxx> > Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@xxxxxxxxxxxxx> > --- > Changes in v6: > - Made this patch first patch of the patch series > > Changes in v5: > - This is the new patch added in v5 version of this patchset > - Moved implementation of setup_port from 8250_pci.c to 8250_pcilib.c > > --- > diff --git a/drivers/tty/serial/8250/8250_pcilib.h b/drivers/tty/serial/8250/8250_pcilib.h > new file mode 100644 > index 000000000000..41ef01d5c3c5 > --- /dev/null > +++ b/drivers/tty/serial/8250/8250_pcilib.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * 8250 PCI library header file. > + * > + * Copyright (C) 2001 Russell King, All Rights Reserved. > + */ You shouldn't depend on .c file having things included for you. So please add these: #include "8250.h" struct pci_dev; Other than that, Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > + > +int serial8250_pci_setup_port(struct pci_dev *dev, struct uart_8250_port *port, u8 bar, > + unsigned int offset, int regshift); -- i.
