On Thu, Dec 01, 2022 at 10:21:43AM +0530, Kumaravel Thiagarajan wrote: > Move implementation of setup_port API to serial8250_pci_setup_port We refer to the functions as func(). Moreover the grammatical period is what each end of sentence should have. > +EXPORT_SYMBOL_GPL(serial8250_pci_setup_port); Make it namespaced from day 1. SERIAL_8250_PCI would be good name for symbol namespaces. -- With Best Regards, Andy Shevchenko
