On Tue, Nov 1, 2022 at 5:25 PM Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > On Tue, 1 Nov 2022, Tharunkumar.Pasumarthi@xxxxxxxxxxxxx wrote: ... > > I went through the code and it seems like this is not taken care by the core. > > Do you suggest calling 'serial8250_em485_config' inside 'pci1xxxx_rs485_config' callback? > > This has not been done since we do not need all the configurations done inside 'serial8250_em485_config'. > > It has nothing to do with serial8250_em485_config. > > It is very hard to believe you couldn't find > uart_sanitize_serial_rs485() and uart_set_rs485_config() yourself, the > latter calls your driver specific rs485 handler. Which version has this API? If it's v6.1-rc1 and patches are made against v6.0, it's possible to miss something. In any case, the patches to the serial subsystem should always be done against the tty/tty-next branch. -- With Best Regards, Andy Shevchenko