> From: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > Sent: Monday, October 3, 2022 2:34 PM > To: Kumaravel Thiagarajan - I21417 > <Kumaravel.Thiagarajan@xxxxxxxxxxxxx> > Subject: Re: [PATCH v2 tty-next 2/3] 8250: microchip: pci1xxxx: Add rs485 > support to quad-uart driver. > > [Some people who received this message don't often get email from > ilpo.jarvinen@xxxxxxxxxxxxxxx. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > + if (rs485->flags & SER_RS485_ENABLED) { > > + memset(rs485->padding, 0, sizeof(rs485->padding)); > > Core handles this for you. I went through the code and it seems like this is not taken care by the core. Do you suggest calling 'serial8250_em485_config' inside 'pci1xxxx_rs485_config' callback? This has not been done since we do not need all the configurations done inside 'serial8250_em485_config'. > > + if (!(rs485->flags & SER_RS485_RTS_ON_SEND)) { > > + data |= ADCL_CFG_POL_SEL; > > + rs485->flags |= SER_RS485_RTS_AFTER_SEND; > > + } else { > > + rs485->flags &= ~SER_RS485_RTS_AFTER_SEND; > > + } > > Core handles that flags sanitization for you. I went through the code and it seems like this is not taken care by the core. Do you suggest calling 'serial8250_em485_config' inside 'pci1xxxx_rs485_config' callback? This has not been done since we do not need all the configurations done inside 'serial8250_em485_config'. > > + } else { > > + memset(rs485, 0, sizeof(*rs485)); > > Core handles this. I went through the code and it seems like this is not taken care by the core. Do you suggest calling 'serial8250_em485_config' inside 'pci1xxxx_rs485_config' callback? This has not been done since we do not need all the configurations done inside 'serial8250_em485_config'. > > + writeb(data, (port->membase + ADCL_CFG_REG)); > > + port->rs485 = *rs485; > > Core handles this. I went through the code and it seems like this is not taken care by the core. Do you suggest calling 'serial8250_em485_config' inside 'pci1xxxx_rs485_config' callback? This has not been done since we do not need all the configurations done inside 'serial8250_em485_config'. Thanks, Tharun Kumar P
