> -----Original Message----- > From: Kumaravel Thiagarajan - I21417 > <Kumaravel.Thiagarajan@xxxxxxxxxxxxx> > Sent: Thursday, September 1, 2022 7:19 PM > To: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > -----Original Message----- > > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > Sent: Wednesday, August 31, 2022 1:26 AM > > To: Kumaravel Thiagarajan - I21417 > > <Kumaravel.Thiagarajan@xxxxxxxxxxxxx> > > > > > > On Tue, Aug 30, 2022 at 9:01 PM Kumaravel Thiagarajan > > <kumaravel.thiagarajan@xxxxxxxxxxxxx> wrote: > > > > > > pci1xxxx's quad-uart function has the capability to wake up the host > > > from suspend state. Enable wakeup before entering into suspend and > > > disable wakeup upon resume. > > > > on resume > Ok. I will modify this. > > > > > ... > > > > First of all, we have pm_ptr() and pm_sleep_ptr() with corresponding > > other macros in pm.h. Use them. > > Second, if you need to duplicate a lot of code from 8250_pci, split > > that code to 8250_pcilib.c and use it in the driver. > Ok. I will review and get back to you. Andy, I was able to start on the v2 for the patch only a few days ago and about to complete it now. I have absorbed most of the changes suggested whereas for the above change I felt it may not be required to split 8250_pci.c at least now as there is only one function setup_port which I have duplicated in 8250_pci1xxxx.c. Please let me know your thoughts. I will submit the v2 patch for review soon. Thank You. Regards, Kumar
