On Tue, Aug 30, 2022 at 9:01 PM Kumaravel Thiagarajan <kumaravel.thiagarajan@xxxxxxxxxxxxx> wrote: > > pci1xxxx's quad-uart function has the capability to wake up the host from > suspend state. Enable wakeup before entering into suspend and disable > wakeup upon resume. on resume ... First of all, we have pm_ptr() and pm_sleep_ptr() with corresponding other macros in pm.h. Use them. Second, if you need to duplicate a lot of code from 8250_pci, split that code to 8250_pcilib.c and use it in the driver. -- With Best Regards, Andy Shevchenko