> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Sent: Wednesday, August 31, 2022 1:26 AM > To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@xxxxxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Jiri Slaby > <jirislaby@xxxxxxxxxx>; Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>; Uwe > Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; Johan Hovold > <johan@xxxxxxxxxx>; Wander Lairson Costa <wander@xxxxxxxxxx>; Eric > Tremblay <etremblay@xxxxxxxxxxxxxxxxxxxx>; Maciej W. Rozycki > <macro@xxxxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; > Jeremy Kerr <jk@xxxxxxxxxx>; Phil Edworthy <phil.edworthy@xxxxxxxxxxx>; > Lukas Wunner <lukas@xxxxxxxxx>; Linux Kernel Mailing List <linux- > kernel@xxxxxxxxxxxxxxx>; open list:SERIAL DRIVERS <linux- > serial@xxxxxxxxxxxxxxx>; UNGLinuxDriver > <UNGLinuxDriver@xxxxxxxxxxxxx> > Subject: Re: [PATCH v1 tty-next 2/2] 8250: microchip: pci1xxxx: Add power > management functions to pci1xxxx's quad-uart driver. > > > On Tue, Aug 30, 2022 at 9:01 PM Kumaravel Thiagarajan > <kumaravel.thiagarajan@xxxxxxxxxxxxx> wrote: > > > > pci1xxxx's quad-uart function has the capability to wake up the host > > from suspend state. Enable wakeup before entering into suspend and > > disable wakeup upon resume. > > on resume Ok. I will modify this. > > ... > > First of all, we have pm_ptr() and pm_sleep_ptr() with corresponding other > macros in pm.h. Use them. > Second, if you need to duplicate a lot of code from 8250_pci, split that code > to 8250_pcilib.c and use it in the driver. Ok. I will review and get back to you. Thank You. Regards, Kumaravel
