On 03.07.19 16:47, Greg KH wrote: > On Wed, Jul 03, 2019 at 03:27:11PM +0200, Enrico Weigelt, metux IT consult wrote: >>> /* UART Port Control Register */> -#define NI8430_PORTCON 0x0f> -#define NI8430_PORTCON_TXVR_ENABLE (1 << 3) >> Can we have that renaming as a separate patch, to ease review ? >> >> And what about introducing a config sym for the new device specific >> stuff ? These devices seem to be pretty rare - never seen them in >> embeded world, where we do need to care of kernel size. > > No, that's not the way this driver works, sorry. That's sad, because in embedded world we often have to care about code size, so making those devices optional would be of great help. OTOH, the 8250 driver already has several such options. What's your concern about adding another one for a new device ? Config variant inflation ? Would putting it behind CONFIG_EXPERT or CONFIG_EMBEDDED an option ? thx. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287
