On 03.07.19 09:24, jeyentam wrote: Hi, besides what Greg already said: > /* UART Port Control Register */> -#define NI8430_PORTCON 0x0f> -#define NI8430_PORTCON_TXVR_ENABLE (1 << 3) Can we have that renaming as a separate patch, to ease review ? And what about introducing a config sym for the new device specific stuff ? These devices seem to be pretty rare - never seen them in embeded world, where we do need to care of kernel size. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@xxxxxxxxx -- +49-151-27565287
