On Wed, Jul 03, 2019 at 03:27:11PM +0200, Enrico Weigelt, metux IT consult wrote: > > /* UART Port Control Register */> -#define NI8430_PORTCON 0x0f> -#define NI8430_PORTCON_TXVR_ENABLE (1 << 3) > Can we have that renaming as a separate patch, to ease review ? > > And what about introducing a config sym for the new device specific > stuff ? These devices seem to be pretty rare - never seen them in > embeded world, where we do need to care of kernel size. No, that's not the way this driver works, sorry. greg k-h