Hi Uli, On Fri, Mar 29, 2019 at 10:46 AM Ulrich Hecht <uli@xxxxxxxx> wrote: > Reviewing the code, I have found another potential issue: the SRR (sampling rate) value is not validated; only values from 7 to 31 are permissible, according to the datasheet. The values in the debug output above would be fine, though. Isn't that handled by .sampling_rate_mask = SCI_SR_RANGE(8, 32), ? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds