On Mon, 2016-09-19 at 09:59:46 +0000, Scott Telford wrote: > > -----Original Message----- > > From: Sören Brinkmann [mailto:soren.brinkmann@xxxxxxxxxx] > > Sent: 16 September 2016 16:46 > > To: Scott Telford > > Cc: linux-serial@xxxxxxxxxxxxxxx; navam@xxxxxxxxxx; > > michal.simek@xxxxxxxxxx; jcmvbkbc@xxxxxxxxx; > > gregkh@xxxxxxxxxxxxxxxxxxx; Anirudha Sarangi; Anirudha Sarangi > > Subject: Re: [PATCH 2/5] serial: xuartps: Rewrite the interrupt handling logic > > > [...] > > The diff in this patch seems larger then it should be. It seems to > > reorder handle_tx and handle_rx and the diff results in ripping out the > > current implementations and putting in something new, hiding the actual > > refactoring. > > > > Sören > > Yes, I agree the reordering is confusing, but I was trying to keep the commits I had cherry-picked from the linux-xlnx tree as intact as possible, so as to help traceability. I can try refactoring Anirudha's changes to be less obfuscatory if you think that's necessary? I think so. Why isn't this change in mainline? Is it needed in mainline at all? The diff makes it pretty much impossible to judge that and the commit message suggests that parts of this change are no longer applicable upstream. I'd prefer a clean diff that makes it easy to understand the changes/refactoring. Sören -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
