RE: [PATCH 2/5] serial: xuartps: Rewrite the interrupt handling logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Sören Brinkmann [mailto:soren.brinkmann@xxxxxxxxxx]
> Sent: 16 September 2016 16:46
> To: Scott Telford
> Cc: linux-serial@xxxxxxxxxxxxxxx; navam@xxxxxxxxxx;
> michal.simek@xxxxxxxxxx; jcmvbkbc@xxxxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; Anirudha Sarangi; Anirudha Sarangi
> Subject: Re: [PATCH 2/5] serial: xuartps: Rewrite the interrupt handling logic
> 
[...]
> The diff in this patch seems larger then it should be. It seems to
> reorder handle_tx and handle_rx and the diff results in ripping out the
> current implementations and putting in something new, hiding the actual
> refactoring.
> 
> 	Sören

Yes, I agree the reordering is confusing, but I was trying to keep the commits I had cherry-picked from the linux-xlnx tree as intact as possible, so as to help traceability. I can try refactoring  Anirudha's changes to be less obfuscatory if you think that's necessary? 

Regards,
Scott.

��.n��������+%������w��{.n�����{��ǫ����{ay�ʇڙ���f���h������_�(�階�ݢj"��������G����?���&��




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux