Hi Scott, On Thu, 2016-09-15 at 15:28:57 +0100, Scott Telford wrote: > From: Anirudha Sarangi <anirudha.sarangi@xxxxxxxxxx> > > The existing interrupt handling logic has followins issues. > - Upon a parity error with default configuration, the control > never comes out of the ISR thereby hanging Linux. > - The error handling logic around framing and parity error are buggy. > There are chances that the errors will never be captured. > - The existing ISR is just too long. > This patch fixes all these concerns. It separates out the Tx and Rx > hanling logic into separate functions. It ensures that the status RX and TX already are in separate functions... > registers are cleared on all cases so that a hang situation never > arises. > > Signed-off-by: Anirudha Sarangi <anirudh@xxxxxxxxxx> > Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> > [stelford@xxxxxxxxxxx: cherry picked from > https://github.com/Xilinx/linux-xlnx commit > ac297e20d399850d7a8e373b6eccf2e183c15165 with manual conflict > resolution] > Signed-off-by: Scott Telford <stelford@xxxxxxxxxxx> The diff in this patch seems larger then it should be. It seems to reorder handle_tx and handle_rx and the diff results in ripping out the current implementations and putting in something new, hiding the actual refactoring. Sören -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html