On 25/06/16 22:07, Arnd Bergmann wrote: > On Saturday, June 25, 2016 2:01:50 PM CEST Greg Kroah-Hartman wrote: >> On Tue, Jun 07, 2016 at 07:06:12PM +0100, Ben Dooks wrote: >>> The driver does not export the two structures that >>> define the uart register mappings outside of the >>> driver, so make them static to avoid the following >>> warnings: >>> >>> drivers/tty/serial/sirfsoc_uart.h:124:30: warning: symbol 'sirfsoc_usp' was not declared. Should it be static? >>> drivers/tty/serial/sirfsoc_uart.h:190:30: warning: symbol 'sirfsoc_uart' was not declared. Should it be static? >>> >>> Note, we don't move these into the driver .c file as this would >>> be a larger change. However they really should not belong in the >>> header file like this. >> >> Please do the correct thing here and move them into the .c file. > > I guess the entire sirfsoc_uart.h file can just get moved in there, > nothing else includes it (obviously, as the symbols above would > otherwise clash). If no-one else objects then i'll sort a second revision. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
