Hi David, On 04/25/2016 12:17 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > On Mon, Apr 25, 2016 at 06:42:30PM +0000, David Binderman wrote: >> Hello there, >> >> ---------------------------------------- >>> How can we make it easier? >> >> Good question. By dropping requirements, i.e. by being less fussy about what can be accepted. >> >> For instance, this trivial patch might be acceptable >> >> --- drivers/tty/serial/8250/8250_port.c.sav 2016-04-25 19:31:07.768472138 +0100 >> +++ drivers/tty/serial/8250/8250_port.c 2016-04-25 19:31:38.080925117 +0100 >> @@ -1815,7 +1815,7 @@ >> status = serial8250_rx_chars(up, status); >> } >> serial8250_modem_status(up); >> - if ((!up->dma || (up->dma && up->dma->tx_err)) && >> + if ((!up->dma || up->dma->tx_err) && >> (status & UART_LSR_THRE)) >> serial8250_tx_chars(up); Fix for this in already in Greg's queue: http://www.spinics.net/lists/linux-serial/msg22261.html > You have to at least format it properly so that we can accept it, we do > have rules for a good reason, see Documentation/SubmittingPatches for > what is needed here (hint, good subject, changelog text, and > signed-off-by line.) I'm always willing to review unfinished/partial patches for tty/serial, clean them up and submit them. Generally, I just need to know that the original author doesn't care that I take over. Regards, Peter Hurley >> I know about 35 other cases like this, scattered across the Linux kernel. > > Great, submit away! > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
