On Mon, Apr 25, 2016 at 05:57:32PM +0000, David Binderman wrote: > Hello there, > > linux-4.6-rc5/drivers/tty/serial/8250/8250_port.c:1818]: (style) Redundant condition: up.dma. '!up.dma || (up.dma && up.dma.tx_err)' is equivalent to '!up.dma || up.dma.tx_err' > > Source code is > > if ((!up->dma || (up->dma && up->dma->tx_err)) && > (status & UART_LSR_THRE)) > > Maybe better code > > if ((!up->dma || up->dma->tx_err) && > (status & UART_LSR_THRE)) > > Also: > > [drivers/tty/serial/8250/8250_port.c:1858]: (style) Variable 'int0' is assigned a value that is never used. > [drivers/tty/serial/8250/8250_port.c:1859]: (style) Variable 'int1' is assigned a value that is never used. > [drivers/tty/serial/8250/8250_port.c:1860]: (style) Variable 'int2' is assigned a value that is never used. > [drivers/tty/serial/8250/8250_port.c:1861]: (style) Variable 'int3' is assigned a value that is never used. Patches are always welcome :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
