On 04/25, Frank Rowand wrote: > > This is in msm_request_tx_dma(). I should have made the message > "msm_serial: TX DMA not enabled\n" and added a similar message > to msm_request_rx_dma(). > > Then it could print twice, once for TX and once for RX. :-) > For my board it would print twice because both requests would > fail for the same reason. Ah right, the 3 line diff window caught me here. > > Should I add it to msm_request_rx_dma() also, but make both > locations dev_debug() instead of dev_info()? Honestly I don't see much point in having this at all. Why does the user care if DMA is used or not? Don't they just want the hardware to work? Maybe dev_dbg(), but again, debug junk. I'll leave it up to you and Greg. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
